MTSR/minetest
3
0
Fork 0
mirror of https://github.com/minetest/minetest.git synced 2024-09-27 10:50:46 +03:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
11,663 Commits 5 Branches 65 Tags 274 MiB
4c001bd248
Commit Graph

7491 Commits

Author SHA1 Message Date
SmallJoker
4ef93fe25f
Allow place_param2 = 0 node placement predictions (#13787) 
The placement prediction value 0 was accidentally ignored
and made the clients fall back to automatic rotation based
on the node paramtype2 value.

This now changes the internal representation to properly
indicate the disabled state (e.g. 'nil' in Lua).
 2023-09-13 13:57:57 +02:00
Gregor Parzefall
833c324498
Make the crosshair DPI-aware (#13772) 2023-09-11 18:59:32 +02:00
Desour
010d08f6a4 Fix -Wmissing-braces warnings in mapblock_mesh.cpp 2023-09-09 18:48:56 +02:00
Desour
7897450b27 Fix -Winconsistent-missing-override warnings 2023-09-09 18:48:56 +02:00
Desour
2ad4c9e0ce Fix -Wunused-but-set-variable warnings 2023-09-09 18:48:56 +02:00
Gregor Parzefall
95056f9783
Higher default graphics settings on Android (#13780) 2023-09-07 17:55:11 +02:00
chmodsayshello
294ad98776
Send ever lasting particle spawners to all players (#13774) 2023-09-02 22:58:11 +02:00
sfan5
f080aa29b5 Remove usage of obsolete HighPrecisionFPU field 2023-09-01 12:46:36 +02:00
Gregor Parzefall
7b56daa236
Small setting-related fixes (#13755) 2023-08-27 20:18:41 +02:00
SmallJoker
bf9f831cb2 Inventory: skip redundant stack movement 
The list of dragged stacks includes the source stack, which
however does not need to be moved onto itself.
This is an optimization.
 2023-08-27 20:12:10 +02:00
SmallJoker
0ba899e239 Inventory: Fix assertion caused by a no-op stack movement 2023-08-27 20:12:10 +02:00
Rising Leaf
660151572f
Do not render objects that are invisble into the shadow map 2023-08-26 20:12:17 +02:00
Desour
f47b00426a Revert "Get rid of guiroot" 
This reverts commit 45e7a80057.
 2023-08-24 22:14:44 +02:00
Desour
7e4dccb3b5 Revert "Get rid of global guienv variable" 
This reverts commit 16da954bd7.
 2023-08-24 22:14:44 +02:00
Desour
f98726c516 Revert "Use our GUIButton in touchscreengui" 
This reverts commit f7f3aaf43c.
Fixes #13743.
 2023-08-24 22:14:44 +02:00
Gregor Parzefall
aea9242a96
Allow nodes to have their post_effect_color affected by lighting (#13637) 
Co-authored-by: DS <ds.desour@proton.me>
 2023-08-24 20:16:36 +02:00
Gregor Parzefall
92b6ff4721
TouchScreenGUI: Fix only 9 hotbar slots being usable (#13698) 
Co-authored-by: Muhammad Rifqi Priyo Susanto <muhammadrifqipriyosusanto@gmail.com>
 2023-08-24 17:45:51 +02:00
Gregor Parzefall
72ef90885d
Clean up texture filtering settings (#13683) 2023-08-24 10:50:47 +02:00
gamefreq0
d0ee63c766
Enable shift-click crafting (#13729) 2023-08-24 12:00:54 +07:00
sfan5
2c987b66c1 Move implementations of some LuaVoxelManip functions to l_mapgen 2023-08-14 18:16:36 +02:00
sfan5
e48f15c135 Skip liquid updates in MapgenSinglenode if not applicable 2023-08-14 18:16:36 +02:00
sfan5
bf36a90579 Optimize Mapgen::updateLiquid() 
-55% runtime in singlenode usage, which is the best case
 2023-08-14 18:16:36 +02:00
sfan5
f9c881eb5a Add two missing classes to async environment 2023-08-14 18:16:36 +02:00
Desour
16da954bd7 Get rid of global guienv variable 
(It can already be accessed via the renderingengine.)
 2023-08-14 18:13:47 +02:00
Desour
45e7a80057 Get rid of guiroot 
The guienvironment already provides a root gui element, we don't need to add another one.
(For CGUIEnvironment, the env itself is the root element.)
 2023-08-14 18:13:47 +02:00
Desour
7e7aceb8c1 Replace all actual uses of irrlicht CGUIStaticText with our StaticText 2023-08-14 18:13:47 +02:00
Desour
d75c956dbc Remove ugly hack in static_text.h 
Just use the root element, like GUIButton:add().
 2023-08-14 18:13:47 +02:00
Desour
f7f3aaf43c Use our GUIButton in touchscreengui 2023-08-14 18:13:47 +02:00
Desour
91c0439922 Use our GUIButton in our GUIScrollBar 
Note that GUIScrollBar needs an ISimpleTextureSource now due to button styling.
 2023-08-14 18:13:47 +02:00
Desour
9d62abbe46 Replace any uses of CGUIScrollBar and IGUIScrollBar with GUIScrollBar 2023-08-14 18:13:47 +02:00
Desour
124d064015 GUIButton: Default BgColor to white, as opposed to unintialized 
(Same as what CGUIButton uses (via colors=0).)
 2023-08-14 18:13:47 +02:00
Desour
2903f692ba GUIButton: Use default member initializers 2023-08-14 18:13:47 +02:00
Desour
7f9de5db0b Make touchscreengui compile 2023-08-14 18:13:47 +02:00
rubenwardy
137e4ce866
Fix hypertext in the mainmenu (#13731) 2023-08-13 13:28:33 +01:00
rubenwardy
c6a0ead72d
Add warning for initial properties directly inside definition (#9650) 2023-08-13 00:19:03 +01:00
Zughy
98f097dc2f
Warn about unsupported file extensions for media 2023-08-06 14:16:00 +02:00
rubenwardy
752ce1a1b2
Settings GUI: Move shadow presets to Shaders, remove Most Used (#13713) 2023-08-05 17:33:18 +01:00
Joachim Stolberg
21ecdd5681
Fix textarea scrollbar inside border=false (#13678) 2023-07-30 14:54:52 +01:00
OgelGames
3f2a10bb4b
Fix decode_base64 returning nothing instead of nil (#13697) 2023-07-30 14:53:47 +01:00
Desour
e0192e256f Fix incorrect rounding in GUIInventoryList::getItemIndexAtPos 2023-07-22 17:19:57 +02:00
ndren
53c594abe0
Introduce and start using microsecond sleep on Linux (#13445) 2023-07-22 17:19:49 +02:00
Gregor Parzefall
6f0d36c41a Fixes and improvements 2023-07-20 22:15:47 +02:00
Gregor Parzefall
7473e4cafd Expose all OpenGL filtering modes, use OpenGL names for them 
Because of a review comment on the Irrlicht PR by numberZero.
 2023-07-20 22:15:47 +02:00
Gregor Parzefall
6bf63d4b41 Rename SMaterial::TextureLayer -> SMaterial::TextureLayers 
It's not the "texture layer" of the material, but an array of texture layers.
 2023-07-20 22:15:47 +02:00
Gregor Parzefall
05ebe2418b Rename E_MATERIAL_FLAG -> E_MATERIAL_PROP 
The enum values don't reference material flags, but material properties.
 2023-07-20 22:15:47 +02:00
Gregor Parzefall
9bef3c136a Split up texture filtering properties of SMaterialLayer into MinFilter and MagFilter 
You can	now set	the filter used	when scaling textures down and the filter used when scaling textures up separately.
 2023-07-20 22:15:47 +02:00
Gregor Parzefall
307e380f30 Refactor the way you set material properties 
Instead of using SMaterial::setFlag, you now set them directly on SMaterial or SMaterialLayer.
 2023-07-20 22:15:47 +02:00
SmallJoker
128d22e6ee
GUI: Automatic scaling of checkboxes and scrollbars (#13666) 
Mainly helpful on high-DPI screens or when 'gui_scaling' is changed
 2023-07-17 20:46:15 +02:00
Nekobit
50234b8e5c
Fix string conversion for FreeBSD (#13648) 2023-07-17 20:46:06 +02:00
Gregor Parzefall
3552537fc4
Fix that transparent text still draws a text shadow (#13649) 
Makes fade out animations of text more pleasant to look at.
 2023-07-17 20:45:56 +02:00
DS
f41e9e3e0f
Add Irrlicht device info to the mainmenu About tab (#13636) 2023-07-17 20:44:54 +02:00
archfan
9b310a6e6f
Decrease sneak margin to combat phasing through thin walls (#13607) 
A 1/16th-node-thick wall is 0.625 meters thick, and the previous margin of 0.1 meters meant that these walls could be phased through by sneaking against them. A margin lower than 0.625 prevents this.
 2023-07-17 20:44:33 +02:00
Muhammad Rifqi Priyo Susanto
2061984313 Simplifies code by using Irrlicht's operator overloads 
New variables are added to replace in-place calculations.
 2023-07-14 21:00:29 +07:00
Muhammad Rifqi Priyo Susanto
3a47559e86 Fix some memory leaks and code style issues 
Maximum line length is 95 characters.
Some members' name are changed.
Struct initialisations use brace syntax; eliminating the usage of the memset function.
Iterations use for-each-loop instead of while-loop+iterator.
char * -> std::string
button_info * -> std::shared_ptr<button_info>
 2023-07-14 21:00:29 +07:00
Desour
8e09077de8 Fix sound manager not being stepped by GUIEngine 2023-07-14 14:42:00 +02:00
Gregor Parzefall
1837a11c22
Improve messages when changing viewing range and exceeding server-set limit (#13647) 2023-07-14 14:41:45 +02:00
sfan5
bf987bf58a Handle blit_back_with_light with empty area 
fixes #13306
 2023-07-13 20:42:39 +02:00
sfan5
4a14a18799 Fix mapgen_v6 crashing 
this variable was accidentally shadowed in 20b10b569
 2023-07-09 20:59:57 +02:00
lhofhansl
136a93f628
Reverse eye-offset Z-coordinate in 3rd person front view (#13369) 2023-07-08 12:00:15 +07:00
Gregor Parzefall
0218963f1b
Fix max_formspec_size not taking gui_scaling into account (#13493) 2023-07-07 21:42:43 +02:00
SmallJoker
078bd95a49
Formspec: prevent infinite loop caused by negative background9[] size (#13624) 2023-07-07 21:42:10 +02:00
lhofhansl
869df17ddf
Server enforcement for fog_distance (#13448) to block cheating (#13643) 
This enforces the fog_distance (if set) at the server, so that a hacked client could not cheat and retrieve blocks beyond the set distance.
 2023-07-06 09:36:46 -07:00
Gregor Parzefall
26453df2f7
Don't crash if a Lua error occurs inside get_staticdata 2023-07-03 20:34:02 +02:00
ROllerozxa
d71872af23
Fix texture paths for system-installed builds 
* window icon
* custom touchscreen checkbox sprites
 2023-07-03 20:31:03 +02:00
Lars Müller
25ef8f3934
Fix local animations not resetting 
Converts `LocalPlayerAnimation` to a scoped enum to prevent such bugs in the future
 2023-07-02 12:47:18 +02:00
lhofhansl
0ade097e99
Allow the server to control fog_distance and fog_start via the sky-api (#13448) 2023-06-30 19:11:17 -07:00
numzero
dde8f0e20a Replace a non-aligned cuboid with a cylinder in client::ActiveObjectMgr::getActiveSelectableObjects 2023-06-29 18:58:10 +02:00
numzero
21035bf5d4 Add unit test on client::ActiveObjectMgr::getActiveSelectableObjects 2023-06-29 18:58:10 +02:00
numzero
d7291e0600 Update client::ActiveObjectMgr::getActiveSelectableObjects API 2023-06-29 18:58:10 +02:00
x2048
c09a3a52ac
Add antialiasing filters (FXAA, SSAA) (#13253) 2023-06-28 05:30:08 +02:00
sfan5
442d5fc75c Add unit tests for isBlockInSight() 2023-06-26 22:51:49 +02:00
numzero
3b74cc4a41 Replace PP with direct printing 2023-06-26 22:51:32 +02:00
numzero
de77fe8ade Allow printing irr::core::vector[23]d directly to an std::ostream 2023-06-26 22:51:32 +02:00
Vitaliy
2f6a9d12f1
Allow running individual unit tests 2023-06-25 11:13:48 +02:00
Vitaliy
aada2403c9
Try all known video drivers if the requested one fails to initialize 2023-06-25 11:13:23 +02:00
Gregor Parzefall
7e51e2dea6 Fix compiler error on MSVC with ENABLE_TOUCH=TRUE 2023-06-24 20:37:59 +02:00
sfan5
84fb663d6c Add VoxelArea::intersect() 2023-06-23 09:05:26 +02:00
sfan5
659828b142 Rename ModApiEnvMod and ModApiItemMod 
The 'mod' could have meant module in the past but no other classes do this.
 2023-06-23 09:05:26 +02:00
sfan5
610578e3e2 Use swapNode for set_node_level and add_node_level 
While this is a behaviour change I don't think the old one made any sense.
It's possible that someone hit this before and wrote a workaround for it,
they won't be affected by this change.
It only makes things work that didn't before.
 2023-06-23 09:05:26 +02:00
sfan5
62629939ff Genericize find_node_near and find_node_in implementations in C++ 2023-06-23 09:05:26 +02:00
sfan5
20b10b5691 Refactor EmergeParams owner 2023-06-23 09:05:26 +02:00
sfan5
32ff832108 Save Lua globals after mod loading 
These are used for the async env currently and will be needed elsewhere soon.
 2023-06-23 09:05:26 +02:00
sfan5
524d446757 Minor script api fixes/cleanups 2023-06-23 09:05:26 +02:00
wsor4035
5b6bc8a12b
Remove unsupported media formats from client.cpp 2023-06-22 17:52:48 +02:00
Gregor Parzefall
03ffc2618c
TouchScreenGUI: Add an exit / "ESC" button to the rare controls bar (#13574) 2023-06-22 17:50:36 +02:00
numzero
7c26cb1c35 Drop unused tile rotations 2023-06-22 17:50:20 +02:00
numzero
1102f92dac Use a enum for tile rotation 2023-06-22 17:50:20 +02:00
numzero
729671d6ae In getNodeTile, use a descriptive struct for the lookup table 2023-06-22 17:50:20 +02:00
numzero
d676520526 Optimize trigonometry out of MapblockMeshGenerator::drawCuboid 2023-06-22 17:50:20 +02:00
numzero
c29d897854 Optimize trigonometry out of MapblockMeshGenerator::drawLiquidTop 2023-06-22 17:50:09 +02:00
numzero
b8ddde0a96 Store liquid data as dimensionless fractions instead of BS multiplies 2023-06-22 17:50:09 +02:00
Desour
03dda13910 OpenALSoundManager: Fix a buffer overflow 2023-06-20 20:54:39 +02:00
lhofhansl
8f25f487fe
Instrument touchMapBlocks and block loading/deserialization. (#13314) 2023-06-19 16:59:08 -07:00
Vitaliy
f1feeb319c
Cull liquid back face on liquid-glasslike interface (#13594) 2023-06-18 13:52:14 -07:00
DS
edcbfa31c9
Sound refactor and improvements (#12764) 2023-06-16 20:15:21 +02:00
Wuzzy
6b3deaa170 Add disable_descend to disable active node sinking 2023-06-16 20:14:08 +02:00
Muhammad Rifqi Priyo Susanto
a4e69d6843
TouchScreenGUI: Read coordinates directly for virtual joystick (#13567) 
The movement's direction and speed are calculated directly from the button's relative screen coordinate. The previous method was to trigger the movement using a keyboard event.
The only virtual joystick status left is Aux1 button.

---------

Co-authored-by: Gregor Parzefall <gregor.parzefall@posteo.de>
 2023-06-16 22:40:16 +07:00
Desour
c549e84abb Silence a -Wsign-compare warning for invlist indices 2023-06-15 13:55:20 +02:00
Desour
dade95e142 Fix curl deprecation warnings, and set minimum curl version to 7.56.0 2023-06-15 13:55:20 +02:00
Desour
f947e2afec Fix some gcc -Wself-move warnings 2023-06-15 13:55:20 +02:00
Desour
6a05d63993 Use [[noreturn]] 2023-06-15 10:38:44 +02:00
Desour
5e6d144567 Enable -Wimplicit-fallthrough and use [[fallthrough]] attribute 2023-06-15 10:38:44 +02:00
Desour
9c348d057e Replace the old STATIC_ASSERT macro with static_assert 2023-06-15 10:38:44 +02:00
Desour
8b108ed5f2 Use nicer syntax for nested namespace definitions 2023-06-15 10:38:44 +02:00
Desour
e700182f44 Replace Optional with std::optional 2023-06-15 10:38:44 +02:00
Desour
34ad551efc Use MutexAutoLock for Thread::m_start_finished_mutex 2023-06-15 10:38:44 +02:00
Pascal Abresch
ba80d1ce1f Implement check_offset for decorations 2023-06-15 10:36:46 +02:00
DS
c91182e1b3
Move the platform-dependent stuff in renderingengine.cpp to irrlicht (#13348) 2023-06-11 14:17:39 +02:00
DS
553dc02deb
Fix some memleaks from GUIButtonImage (#13564) 
* `m_foreground_image` was grabbed, but not dropped in the destructor.
* `m_image` was created with new. It is grabbed by itself and by the env (not only by the env!, so it's an owning ptr). This owning ptr also was never dropped.
 2023-06-06 19:01:32 +02:00
Desour
1b51ff333a Use unique_ptr for ServerInventoryManager::DetachedInventory::inventory 2023-06-05 20:43:33 +02:00
Desour
1780d1bbde Use unique_ptrs for MapSector::m_blocks 2023-06-05 20:43:33 +02:00
Desour
08ea467bfe Use unique_ptr for g_httpfetch_thread 2023-06-05 20:43:33 +02:00
Desour
cfb1b879e0 Use unique_ptrs for CurlFetchThread::m_all_ongoing 2023-06-05 20:43:33 +02:00
Desour
d0bcdff5ce Use unique_ptrs for leveldb db and iterators 2023-06-05 20:43:33 +02:00
Gregor Parzefall
a1463263b5
Auto-detect locale on Android (#13561) 2023-06-05 12:02:10 +02:00
Gregor Parzefall
a857c46e6e
Make the settings GUI more usable on Android (#13543) 2023-06-05 12:01:54 +02:00
Desour
d9f478cbfb Remove a misleading MutexAutoLock in l_to_table 
The temporary is immediately destructed, so the mutex isn't locked
after the line.
Removed the lock, because the Settings member-functions used by
push_settings_table lock the mutex and are thread-safe, but would
cause a dead-lock.
 2023-06-05 12:01:08 +02:00
OgelGames
252c79d53a
Inventory mouse shortcut improvements (#13146) 
Co-authored-by: Muhammad Rifqi Priyo Susanto <muhammadrifqipriyosusanto@gmail.com>
 2023-06-05 12:00:32 +02:00
Riley Adams
29b7aea38b
Cavegen y biome check (#13472) 2023-06-05 11:59:22 +02:00
Muhammad Rifqi Priyo Susanto
7221de6ede Option to invert direction or disable mouse wheel for hotbar item selection 
More changed callbacks for the settings are added in readSettings(). Those are also deregistered when the Game object is destroyed.
 2023-05-31 12:40:00 +07:00
Treer
8cd1296049
Add additional texture modifiers (#10100) 
* Adjust hue, saturation, and lightness
* Colorize using hue, saturation, and lightness
* Adjust contrast & brightness
* Hard light
* Overlay
* Screen
* Create texture of a given size and color
 2023-05-29 20:17:39 +01:00
lhofhansl
a8ec6092e2
Load blocks and objects behind player when in third-persion front-view (#13431) 2023-05-29 10:26:42 -07:00
Gregor Parzefall
fc3d6c1dd9
Place nodes with single tap on Android (+ bugfix) (#13187) 
Don't place nodes when closing button bars.
Update docs (also in-game).
Rename "Default controls" -> "Controls" in Android pause menu since players can't change them (normally), so calling them "default" doesn't make sense.
 2023-05-29 12:30:30 +07:00
lhofhansl
6832bf044e
Avoid jittering when player is attached (#12439) 
* Avoid very jittering when player is attached.

Co-authored-by: sfan5 <sfan5@live.de>
Co-authored-by: Vitaliy <numzer0@yandex.ru>
 2023-05-28 11:36:34 -07:00
sfan5
8cccd75e81
Android build via CMake (#13528) 
* the thing

* the thing 2
 2023-05-26 15:21:23 +02:00
Thresher
00c647e4cc
Convert spaces to tabs (#13506) 
* Convert spaces to tabs

* Desour reviews 1-3 fix

* Desour fixes

* Undo alignment changes
 2023-05-26 15:13:57 +02:00
ROllerozxa
f4cb16cc2d
Disable desynchronize_mapblock_texture_animation by default (#13514) 2023-05-26 13:48:37 +02:00
Zughy
d6eb6ff973
Reset player lighting when passing no arguments (#13525) 
Co-authored-by: Zughy <4279489-marco_a@users.noreply.gitlab.com>
 2023-05-26 13:47:16 +02:00
Zughy
b60d38b7f9
Reset day/night ratio even when passing no arguments (#13524) 
* reset day_night_ratio when passing zero fields

* Update lua_api.md

---------

Co-authored-by: Zughy <4279489-marco_a@users.noreply.gitlab.com>
 2023-05-26 13:45:42 +02:00
Thresher
180ec92ef9
Remove trailing whitespace (#13505) 2023-05-18 20:34:18 +02:00
SmallJoker
95a9f4ab7c
Inventory: Allow InvRef:set_list with new_size >= old_size (#13497) 
Fixes a regression introduced by enforced checks to work with
valid pointers within inventory actions.
 2023-05-18 20:32:55 +02:00
Gregor Parzefall
f393214fef
Settings menu improvements regarding default values (#13489) 
The reset button now removes the setting from minetest.conf instead of setting it to its default value.
The reset button is now shown whenever a value is present in minetest.conf
Float settings now get a .0 suffix if they have no decimal places.
 2023-05-18 20:32:26 +02:00
savilli
5ba70cf5ef
Fix crash on handling wallmounted nodes with invalid param2 (#13487) 2023-05-18 20:31:04 +02:00
Zemtzov7
35112f2453
Disable vertical movement when both jump and sneak keys are pressed (#13426) 2023-05-18 20:30:21 +02:00
Gregor Parzefall
15fb4cab15
Fix Android segfault when game exits before TouchScreenGUI is initalized 2023-05-11 22:51:16 +02:00
sfan5
15445a0fbe Raise and clean up _WIN32_WINNT constant 2023-05-11 22:51:01 +02:00
Wuzzy
80574cdbe8
Fix rotation of 4dir in schematic placement (#13432) 2023-05-11 22:50:52 +02:00
Buckaroo Banzai
65692ad1b5
Add min/max protocol version to minetest.get_version() (#13482) 2023-05-06 16:16:21 +01:00
DS
bec9c68bf3
Release invlist resizelock while doing the recursive callback in move_somewhere mode (#13470) 
Fixes a crash in popular creative inventory mods that set the list when you put
something into trash.
 2023-04-30 18:20:48 +02:00
lhofhansl
b35aa10579
Guarantee ActiveObjectMgr::m_active_object is not modified while iterating (#13468) 
Currently if a mod creates new active objects in on_deactivate the server could crash.
 2023-04-28 11:17:48 -07:00
Desour
7f6b09dce8 Use json forward-declarations 2023-04-27 18:50:33 +02:00
Desour
8b73743baa Reduce number of recursively included headers 
This should improve compilation speed.

Things changed:
* Prefer forward-declarations in headers.
* Move header-includes out of headers if possible.
* Move some functions definitions out of headers.
* Put some member variables into unique_ptrs (see Client).
 2023-04-27 18:50:33 +02:00
Desour
e9e8eed360 GUIChatConsole: Use primary selection 2023-04-27 18:50:17 +02:00
Desour
062b4d036a GUIEditBox: Use primary selection 2023-04-27 18:50:17 +02:00
SmallJoker
0fb6dbab36
InventoryManager: Disallow resizing or deleting inventory lists that are in use (#13360) 
Naive solution to prevent InventoryList UAF and OOB ItemStack access caused by shrink/clear operations on InventoryLists within callbacks of an inventory action.

Co-authored-by: Desour <ds.desour@proton.me>
 2023-04-22 17:42:36 +02:00
rubenwardy
4158b72971
Add ability to override item images using meta (#12614) 2023-04-17 19:44:41 +01:00
rubenwardy
b1786e88ac Use .md extension for markdown files 
Linking to line numbers is brittle, linking to sections/headings is better.

If you still want to link to a line number, you can append ?plain=1 to GitHub's URL
 2023-04-16 20:23:53 +01:00
rubenwardy
5cd6a22dd3
Update settingtypes (#13428) 
* Move settings to correct sections
* Improve titles and descriptions
* Make defaults in settingtypes.txt and defaultsettings.cpp match

Fixes #9002
 2023-04-14 22:32:25 +01:00
Desour
ccd696c49a Throw Hocroft-Karp onto shapeless recipes 2023-04-14 21:10:09 +02:00
Desour
50e91b882c Add some simple unittests for shapeless recipes 
Note: devtest also has craft unittests (see devtest/mods/unittests/crafting.lua),
      but those aren't run at load-time.
 2023-04-14 21:10:09 +02:00
DS
ae7271b725
Fix background[] pos-offset lower-right-corner being at least (1,1) (#13320) 
IGUIElement has a MinSize for the RelativeRect, which is at least (1,1).
This means a pos offset of (0,0) will cause a seemingly off-by-1 error at the
lower right corner, and (0.1,0.1) for example will just not work on the lower
right corner.
Ergo, we can't use the AbsoluteRect for storing the pos offset.
 2023-04-14 21:05:09 +02:00
DS
d49d80a4a0
Store whether window is maximized (#12861) 2023-04-14 21:04:03 +02:00
Lars
f9b1176fa9 Track server's max AsyncRunStep 2023-04-14 00:09:48 +01:00
Lars
3d232e2345 Add MAX profiler option 2023-04-14 00:09:48 +01:00
rubenwardy
9d1ae80e89
Add focused styling to buttons (#13414) 2023-04-14 00:09:29 +01:00
Gregor Parzefall
2a1bc82887
Fix black loading screen background if menu_clouds = false (#13322) 2023-04-13 18:12:48 +01:00
Wuzzy
d1e5dbefc7
Clarify documentation of punch key (#13238) 2023-04-13 18:12:26 +01:00
Desour
fc116ec950 Play object footstep sound at feet 2023-04-13 18:12:13 +01:00
Zardshard
e139749b5c
Simulate all keys being released when when game loses focus (#13336) 2023-04-13 18:06:21 +02:00
rubenwardy
2fc7eb3ea2
Remove formspec_default_bg_color/opacity settings (#13419) 
These settings are unnecessary. They only apply when formspecs don't have a background/bgcolor set. In practice, most games do theme their GUIs. Removing low value settings simplifies code and improves UX by decluttering the settings menu

Split out from #12140
 2023-04-11 19:57:36 +01:00
Desour
1dd13da37d Get rid of global dummySoundManager 
There is no need for this to be globally unique.
 2023-04-11 20:06:15 +02:00
Desour
b201c03625 Use smart-ptrs in GUIEngine 2023-04-11 20:06:15 +02:00
Desour
ceec560779 Add make_irr 2023-04-11 20:06:15 +02:00
Riley Adams
73391013f7
Add node pos to node damage HP change reason (#13196) 2023-04-10 23:04:52 +01:00
Lars
4a742be73e Do not call updateDrawList, updateDrawListShadow, and touchMapBlocks in the same frame 2023-04-09 07:10:17 -10:00
Lars
8982998681 Add a default direction light for shadows 2023-04-09 07:10:17 -10:00
sfan5
9d736e8b8b Drop ENABLE_GLES option 
ENABLE_GLES predates forking Irrlicht. Its primary use was to distinguish Irrlicht-ogles from upstream version as Minetest could be compiled with either.
That's not necessary anymore and gets in the way sometimes.
 2023-04-08 20:19:35 +02:00
sfan5
c26e122485 Move video_driver default selection to runtime 2023-04-08 20:19:35 +02:00
Desour
67068cfaf4 Get rid of wgettext 2023-04-08 20:17:50 +02:00
Vitaliy
35929d27e3
Remove fast faces (#13216) 
Co-authored-by: Lars <larsh@apache.org>
 2023-04-08 20:17:15 +02:00
SmallJoker
ba2fee0751 Particle spawner: Fix missing parameters 
The changes done to clientpackethandler.cpp and server.cpp move the
compatibility code into a protocol version check so that older code
parts can easily be removed in the future (e.g. bump of minimal version).
 2023-04-08 17:23:17 +02:00
SmallJoker
f8e0778fc9 Particle spawner: Move definitions to source 
Long functions were moved to the source file to keep the header
short to speed up compiling. This has no functional change.
 2023-04-08 17:23:17 +02:00
SmallJoker
9c9309cdbb
Lua API: Catch serialization error for chat messages (#13337) 
Prevents server errors caused by too long chat messages from the Lua API.
 2023-04-07 12:49:35 +02:00
SmallJoker
d975ebdcb9
Limit formspec fields to 640K (#13380) 
Fixes an issue where long inputs could cause issues when dealing with formspecs.
The expected data is usually below 1 KiB, however that's not a technical limit.
 2023-04-07 12:49:23 +02:00
Lars
7048fc25dd Take mesh-bounding-sphere into account in updateDrawListShadow 2023-04-03 13:57:05 -07:00
Lars
b01f85d573 Revert "Add mesh-holding blocks to shadow drawlist. (#13203)" 
This reverts commit 2a8becd650.
 2023-04-03 13:57:05 -07:00
SmallJoker
1c1f1b1615 Revert "Enable connected glass by default (#13242)" 
This reverts commit a93f3542d9 for
the upcoming 5.7.0 release.

See https://github.com/minetest/minetest/issues/8290 for a detailed discussion.
 2023-04-02 20:56:31 +02:00
x2048
6c0a6925fc
Corrections to loops and BFS cullers (#13375) 
* Reset usage timers in loops culler
* Correctly touch map blocks when using bfs culler
* Align use of variables
* Report statistics when using loop culler
 2023-04-01 22:41:00 +02:00
sfan5
819e9fc615 Do not rely on ZSTD_CLEVEL_DEFAULT define 2023-04-01 22:06:03 +02:00
lhofhansl
48fc286a95
Restart map-send cycle if visible blocks are soon to be unloaded. (#13277) 
* Restart map-send cycle if visible blocks are soon to be unloaded.
* Reset completion timer when camera or position changed.

Co-authored-by: sfan5 <sfan5@live.de>
 2023-03-30 09:19:13 -07:00
x2048
93898957b6
Return 'loops' occlusion culler under a setting (#13352) 
* Add occlusion_culler setting to minetest.conf.example
* Add raytraced occlusion culling to 'loops' algorithm

---------

Co-authored-by: sfan5 <sfan5@live.de>
 2023-03-30 00:10:23 +02:00
sfan5
bd88d299b9 Bump protocol version 
and correct documentation of previous version
 2023-03-29 23:19:39 +02:00
DS
2180dc14ef
Fix safeLoadFile() skipping 2 chars too much from the shebang (#13310) 2023-03-27 20:01:05 +02:00
DS
ed632f3854
Safely handle block deletion (#13315) 
Co-authored-by: Jude Melton-Houghton <jwmhjwmh@gmail.com>
 2023-03-24 12:34:44 +01:00
x2048
f3b198e490
Return shadow_sky_body_orbit_tilt setting 
Used as a default value when the game does not change the value via API (e.g. legacy server)
 2023-03-24 12:34:21 +01:00
x2048
9af587c54e
Move rendering engine reset after deletion of game objects 2023-03-20 11:42:16 +01:00
x2048
6cd2eea487
Move drawing of wield tool into a dedicated step of the pipeline (#13338) 2023-03-19 21:31:15 +01:00
luk3yx
5fa63a0b0c
Fix server-side formspec state keeping issue (#13332) 2023-03-19 20:23:11 +01:00
x2048
6fe9bc8ae1
Remove obsolete rendering core init code (#13341) 
Also removes duplicate call to shadow render step
 2023-03-19 20:22:45 +01:00
Gregor Parzefall
38e005294f
Remove default keybind for pitchmove (#13319) 2023-03-16 14:57:44 +01:00
x2048
2bed338ef7
Fix occasional black screen on startup 2023-03-16 14:56:27 +01:00
Jude Melton-Houghton
b7359f5fa9 Update nodes in LBM loop 2023-03-13 18:17:07 +01:00
DS
cac1dca95b
Improvement of #12974: better linear independent vector (#12979) 2023-03-13 18:16:07 +01:00
DS
02346819f9
Fix rendertarget size being saved as screensize (#13313) 2023-03-12 19:56:49 +01:00
lhofhansl
3e148e2810
Fix infinite viewing_range (#13225) 
Use a simplified version of the old loops culler for infinite viewing range.
 2023-03-12 09:37:47 -07:00
DS
b1ed0ef721
Fix ChatPrompt crash in very narrow windows (#13305) 
In very narrow windows, `m_cols` can be small (i.e. 0).
Hence, `m_view <= m_line.size() + 1 - m_cols` does not guarantee
`m_view <= m_line.size()`.
`std::string::substr(pos, npos)` requires `pos <= size()`.
 2023-03-11 17:46:49 +01:00
x2048
705195b43e
Scale culler steps proportionally to the mesh sizes (#13250) 2023-03-11 14:10:26 +01:00
updatepo.sh
c77f3d4dc4 Update minetest.conf.example and translation file 2023-03-09 15:38:46 +01:00
lhofhansl
1f0d042377
Reduce server CPU consumed by occlusion culling. (#13260) 
Cache blocks already occluded at a specific distance. The RemoteClient typically visits the same distance multiple time - especially at larger distances, so this saves significant CPU from recalculating the occlusion state of blocks.
 2023-03-05 21:33:41 -08:00
ROllerozxa
c91f3f99fd
Minor adjustments now that OpenGLES 2 is the default driver on Android (#12391) 2023-03-05 15:07:40 +01:00
SmallJoker
847ed04e0a Tile: Fix segfault caused by invalid PNG data 2023-03-05 14:41:55 +01:00
Lars
e66e583f5e Remove accidental emacs files. 2023-03-03 17:51:45 -08:00
lhofhansl
dcf6a6a67b
Log server map send cycle time. (#13259) 
* Measure server map send time per player.
 2023-03-03 17:41:30 -08:00
sfan5
915befecc5 Re-enable verbose logging on Android 
Without recompiling, there's no way to see it in logcat otherwise.
 2023-03-02 19:57:18 +01:00
PrairieWind
a93f3542d9
Enable connected glass by default (#13242) 2023-03-02 19:56:55 +01:00
numzero
d6be6682ec Drop dependency on IrrCompileConfig 
The only remaining thing is IRRLICHT_SDK_VERSION via irrlicht.h
 2023-03-01 09:06:23 +01:00
rubenwardy
39f4d26177
Add minetest.get_player_window_information() (#12367) 2023-02-27 22:58:41 +00:00
lhofhansl
fbbdae93ee
Fix for #13255: Check if client has a block even if the server has unloaded it. (#13256) 2023-02-27 09:57:03 -08:00
lhofhansl
fe3ea090d1
Don't expire blocks visible to the client. (#13255) 2023-02-26 14:18:18 -08:00
sofar
2083252c05
Sky: transmit body_orbit_tilt to client. (#13193) 
This obsoletes the current client-side setting entirely. The server can
transmit the tilt to the client directly and will send 0.0f as default
value.

Co-authored-by: x2048 <codeforsmile@gmail.com>
Co-authored-by: sfan5 <sfan5@live.de>
 2023-02-26 01:08:33 +01:00
DS
6e1c70e02b
Fix a -Wreorder warning 2023-02-22 11:06:48 +01:00
lhofhansl
63c378fb5b
Reduce client's packet processing budget per iteration from 100 to 10ms. (#13237) 2023-02-21 16:33:21 -08:00
x2048
2553db5c81
Fix rounding errors when slicing the shadow draw list (#13226) 2023-02-20 21:01:05 +01:00
Alex
af4009d924
Add chat HUD flag (#13189) 2023-02-20 21:00:37 +01:00
paradust7
aa5dc0968b
Fix typo and missing entry in serveropcodes 2023-02-18 16:47:08 +01:00
sfan5
3bafbaac49 Remove dead code behind Irrlicht version checks 2023-02-18 16:46:51 +01:00
20kdc
75e6cc190a
Source image tracking in tile generation (#12514) 2023-02-18 00:03:03 +01:00
lhofhansl
2a8becd650
Add mesh-holding blocks to shadow drawlist. (#13203) 
When mesh chunking and shadows are enabled, make sure that the mesh-holding blocks are added to the shadow drawlist.
Otherwise those portions of the shadows will not be rendered.
 2023-02-16 15:43:08 -10:00
lhofhansl
d3a6ee00e6
Generalize mesh chunking, and make it configurable. (#13179) 
* Generalize mesh chunking. Set 3x3x3 chunks.

* Make mesh chunk size configurable... Default to 1 (off).

* Extract all mesh grid maths into a dedicated class

---------

Co-authored-by: x2048 <codeforsmile@gmail.com>
 2023-02-08 13:42:12 -08:00
lhofhansl
56d2567b5d
Separate drawlist from non-rendered blocks. (#13176) 2023-02-01 08:41:23 -08:00
x2048
69fc206109
8x block meshes (#13133) 
Reduce the number of drawcalls by generating a mesh per 8 blocks (2x2x2). Only blocks with even coordinates (lowest bit set to 0) will get a mesh.

Note: This also removes the old 'loops' algorithm for building the draw list, because it produces visual artifacts and cannot be made compatible with the approach of having a mesh for every 8th block without hurting performance.

Co-authored-by: Jude Melton-Houghton <jwmhjwmh@gmail.com>
Co-authored-by: Lars <larsh@apache.org>
Co-authored-by: sfan5 <sfan5@live.de>
 2023-01-31 17:30:59 +01:00
lhofhansl
cded6a3945
Display whole profiler numbers up to 999999 without scientific notation. (#13155) 2023-01-24 17:40:23 -08:00
x2048
b8aaad4f1e
Remove the 'loops' occlusion culler (#13169) 2023-01-23 10:58:29 +01:00
DS
8478796226
Decrease minimum for repeat_place_time (#13165) 2023-01-23 00:20:12 +01:00
sfan5
87d509e462
Implement --debugger option to improve UX when debugging crashes (#13157) 2023-01-23 00:19:30 +01:00
x2048
6f5703baf1
Clear exposure compensation state textures on creation (#13151) 2023-01-23 00:18:48 +01:00
x2048
ca13c51024
Fix concurrency in texture source (#13150) 2023-01-19 21:44:27 +01:00
SmallJoker
ecd6d61697
Revisit F6 statistics formatting (#13126) 2023-01-16 20:16:23 +01:00
Jude Melton-Houghton
2f9f0c0900
Improve chat history (#12975) 2023-01-14 16:14:37 -05:00
sfan5
8fded9d990
Disable Prometheus in singleplayer mode 2023-01-14 13:11:15 +01:00
Jude Melton-Houghton
3992a13f24
Improve MetaDataRef:{get,set}_float precision (#13130) 2023-01-12 15:40:34 -05:00
Jude Melton-Houghton
5f2925c59c
Increase ftos precision (#13141) 2023-01-12 14:12:31 -05:00
Jude Melton-Houghton
956026bb6b
Break long lines of option help (#13136) 2023-01-12 14:12:05 -05:00
x2048
139db66901
Remove mapblock cache for mesh generation. (#13124) 
Reduces memory consumption and improves performance
 2023-01-09 21:40:08 +01:00
ROllerozxa
390b5caaaa
Fix crash on Android with IrrlichtMt9 (#13123) 
Caused by mouse control
 2023-01-08 14:04:17 +01:00
iliekprogrammar
fb28ca463e
Clamp player wieldindex when processing hotbar item selection (#13098) 2023-01-08 14:03:16 +01:00
lhofhansl
55804c56e9
Report collisionMoveSimple for client and server. (#13105) 2023-01-07 16:31:31 -08:00
ROllerozxa
bb74da5903
Remove old rollback migration code (#13082) 2023-01-06 22:35:20 +01:00
x2048
6d45c243f8
Add dynamic exposure correction (#12959) 
* Add uniform for frame delta time
* Adjust exposure in logarithmic (EV) space
* Add network support and LUA API
* Add testing mod
 2023-01-06 22:33:25 +01:00
x2048
2715cc8bf6
Occlusion culling algorithm based on recursive descend (#13104) 
Co-authored-by: DS <vorunbekannt75@web.de>
 2023-01-06 22:31:06 +01:00
sfan5
059f62d7d6 Use consistent optimization flags for *BSD 
This was added for seemingly no reason in c410e9182d (2014)
 2023-01-05 23:09:51 +01:00
x2048
89e7f72c92
Use multiple threads for mesh generation (#13062) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-12-27 18:44:18 +01:00
SmallJoker
03e710160f
Lua API: Document shader dependencies of set_lighting() (#13079) 2022-12-26 21:59:55 +01:00
lhofhansl
1e7804aaf6
Allow saturation to be controlled by the server. (#13075) 2022-12-25 16:15:32 -08:00
ROllerozxa
afd5caa26a
Fully remove pageflip 3D mode (#13074) 2022-12-25 10:57:39 -05:00
Jean-Patrick Guerrero
33363c2a7e
Fix progress bar look on HiDPI displays (#13055) 2022-12-24 12:26:56 -05:00
Jude Melton-Houghton
d13b12b791
Store MapEditEvent blocks in a vector (#13071) 2022-12-24 12:21:59 -05:00
Jude Melton-Houghton
5c248c2d7d Add callback on_mapblocks_changed 2022-12-24 08:24:59 -05:00
Jude Melton-Houghton
7701e70dc9 Make MapEditEvent more complete 
SetBlocksNotSent is no longer used.
 2022-12-24 08:24:59 -05:00
ndren
62ee02b8ba
Set and unset relative mouse mode where necessary (#12636) 
* Set and unset relative mouse mode where necessary

Co-authored-by: sfan5 <sfan5@live.de>
 2022-12-24 09:38:30 +01:00
Jude Melton-Houghton
0fc97a1483
Use a Lua error handler that calls tostring (#11913) 2022-12-15 07:37:49 -05:00
Jude Melton-Houghton
1f3b5e553b
Fix plantlike_rooted world-aligned node base textures (#12994) 
Co-authored-by: Wuzzy <Wuzzy@disroot.org>
 2022-12-12 08:45:09 -05:00
updatepo.sh
111d047b0a Update minetest.conf.example 2022-12-10 15:35:46 +01:00
Jude Melton-Houghton
c18c082059
Prevent air acceleration with 0 jump speed (#13036) 2022-12-10 09:08:50 -05:00
Jude Melton-Houghton
1798ad0ec4
Avoid out-of-bounds memory access in attached node placement prediction (#13038) 2022-12-10 09:00:27 -05:00
sfan5
37386b9c3c
Expose dtime_s to LBM handler 2022-12-04 12:35:14 +01:00
Jude Melton-Houghton
b3ffc4b327
Add minetest.get_mapgen_edges (#12999) 2022-12-03 10:40:46 -05:00
lhofhansl
e84d259ec7
Remove shader caching hack. (#12991) 2022-11-30 13:56:14 -08:00
Muhammad Rifqi Priyo Susanto
281f9a9f88
Android: Segmentation fault fix, PendingIntent flag, and other fixes (#12960) 
* Android: Segmentation fault fix, PendingIntent flag, and other fixes

- Information about the crosshair is sent after camera initialization.
- Since API 31, PendingIntent requires mutability flag.
- super (class) is called in onRequestPermissionsResult().
- GameActivity suppresses "unused" warning since most of its methods are called from native code.
- Non-null safety is added for nullable function calls.
- Warning/error logging is added for various function calls' return value.

* Move utility functions into Utils.java

- Some nullable functions are changed to be non-null functions.
- Some null checking outside it is removed.
- More annotations are added to functions and parameters.
 2022-11-30 10:50:06 -05:00
Jude Melton-Houghton
055fc69c11
Handle num lock in chat (#12984) 2022-11-30 10:43:12 -05:00
Jude Melton-Houghton
38169db765
Wrap debug text on screen (#12978) 2022-11-28 12:17:36 -05:00
Jude Melton-Houghton
d0a118f5b1
Add minetest.get_game_info and allow reading game.conf (#12989) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-11-28 07:21:43 -05:00
Jude Melton-Houghton
3fd5bff128
Abort active ABM iteration when content changes (#12998) 2022-11-27 15:55:10 -05:00
Muhammad Rifqi Priyo Susanto
40a45b8c99
Virtual joystick: Use s32 when using m_screensize as a subtrahend (#12814) 
If still uses u32, m_screensize will yield a big value (underflow) when used as a subtrahend.
ETIE_MOVED is allowed to be run if joystick's ID is available and virtual joystick is fixed.
Add .0f for some float values.
 2022-11-26 09:16:14 -05:00
savilli
f04d4d0291 Fix touchscreen crash due to missing rangeselect 2022-11-25 19:57:03 +01:00
Jude Melton-Houghton
8b26bab37d Remove unnecessary bool return types 2022-11-24 17:58:25 -05:00
Jude Melton-Houghton
7c21347a40 Rename "mod metadata" to "mod storage" everywhere 2022-11-24 17:58:25 -05:00
Jude Melton-Houghton
8817af07fb
Deprecate special handling of ${key} syntax in metadata values (#12970) 2022-11-24 17:56:43 -05:00
Wuzzy
3c7f26d937
Add support for attached facedir/4dir nodes (#11432) 2022-11-24 17:56:07 -05:00
x2048
1c10988d6a
Fix entity visiblity in bright artificial light (#12906) 2022-11-23 22:40:26 +01:00
Jude Melton-Houghton
9527cc3fa0
avoid clearChildAttachments iterator invalidation (#12987) 2022-11-23 14:48:12 -05:00
Jude Melton-Houghton
386bfcda2b
Fix reading schematics after their resolution (#12985) 2022-11-23 11:53:21 -05:00
Jude Melton-Houghton
4da8a18c8c
Check specific outputs for isatty (#12980) 2022-11-21 12:08:40 -05:00
x2048
70a82b0784
Avoid shadow flicker at certain angles (#12961) 
Change the way look direction and camera position are quantized when calculating light frustum
 2022-11-20 21:28:01 +01:00
DS
5f24a3c0c7
Object selection: Improve distance checks (#12974) 2022-11-20 21:27:47 +01:00
lhofhansl
7bf64fc61a
Add configurable saturation (#12865) 
* Add configurable saturation

Co-authored-by: Pevernow <3450354617@qq.com>
Co-authored-by: x2048 <codeforsmile@gmail.com>

Author:    Lars <larsh@apache.org>
 2022-11-18 11:49:52 -08:00
Riceball LEE
6bf662cb9e
set_nametag_attributes: don't reset nametags if text param is not touched 
fixes #12901
 2022-11-15 16:46:26 +01:00
SmallJoker
8de9e2ac84
game.conf: Add setting to use volatile a map backend (#12956) 2022-11-15 16:45:48 +01:00
Jude Melton-Houghton
cd8a7fe472
Add MetaDataRef:get_keys (#12841) 2022-11-15 16:45:12 +01:00
lhofhansl
1a045da0dd
Reduce active mgmt interval for a bit when a player joins. (#12925) 2022-11-10 15:25:38 -08:00
Jude Melton-Houghton
00eb65915f Add PostgreSQL helper pg_to_string 2022-11-10 18:56:48 +01:00
Jude Melton-Houghton
aaa05f901a Add mod storage PostgreSQL backend 2022-11-10 18:56:48 +01:00
Jude Melton-Houghton
9dbac989bd Improve testListMods 2022-11-10 18:56:48 +01:00
Gregor Parzefall
88b04eadc9
Fix get_tool_wear_after_use for one use (insta-break) (#12945) 2022-11-09 11:58:53 -05:00
x2048
81bfc9c7a2
Resize hotbar immediately before drawing (#12930) 2022-11-09 11:57:55 -05:00
Abdou-31
d1b80b462e
Fix typos and en_US/en_GB inconsistency in various files (#12902) 2022-11-09 11:57:19 -05:00
Loïc Blot
322c8cf270
Reduce exposure of various internals (#12885) 
* refactoring(StaticObjectList): don't expose m_active and m_stored anymore

This prevents our old crap code where anyone can access to StaticObjectList. use proper modifiers. It also permits to do a short cleanup on MapBlock using a helper

* refactoring(MapBlock): reduce a bit exposed m_active_blocks variable

* refactoring: MapBlock::m_node_timers is now private

We already had various helpers to perform this privatization, just use it. Also factorize the MapBlock stepping code for timers using already existing code and importing them from ServerEnvironment to MapBlock.

It's currently done pretty straight forward without any inheritance as MapBlock is just used everywhere, maybe in a future we'll have ServerMapBlock over MapBlock. Currently for a simple function let's just use proper objects and add a comment warning

* refactoring(Server): fix duplicated function for add/remove node

* refactoring(guiFormSpecMenu): add removeAll function to prevent duplicated code

* refactoring(ShadowRenderer) + perf: code quality  + increase performance

* All callers are already using the point and we should never test a function with nullptr node, it's a bug. Removed workaround which was hacky and fix the bug
* Drop clientmap lookup from shadowrendered, just use directly its
  pointer and forbid to push it in the generic list
* Reduce memory pressure on the renderShadowObject by preventing
  deallocating and reallocating multiple vectors on each node

* refactoring(MapBlock): reduce exposure of MapBlock::m_static_objects

It's not complete as some parts of the code are pretty nested, but it's better than before :)

* fix: better working on new functions & drop unwanted 2 lines

Co-authored-by: Jude Melton-Houghton <jwmhjwmh@gmail.com>

Co-authored-by: Jude Melton-Houghton <jwmhjwmh@gmail.com>
 2022-11-03 17:35:31 +01:00
x2048
9b24041394
Improve bloom effect (#12916) 
* Remove the built-in exposure factor of 2.5
* Add physics-based bloom (https://learnopengl.com/Guest-Articles/2022/Phys.-Based-Bloom)
* Add luminance scaling for bloom layer to simulate HDR
* Add setting to control bloom strength
 2022-11-02 09:09:48 +01:00
Muhammad Rifqi Priyo Susanto
987277de52
Send crosshair setting after the touch screen GUI has been initialized (#12910) 2022-10-31 14:17:50 +01:00
Lars Mueller
88af36dd10 Fix node placement regression 2022-10-31 14:17:28 +01:00
x2048
260de1c2b5
Enable negative values for sun/moon orbit tilt (Northern hemisphere) (#12904) 2022-10-30 16:54:06 +01:00
x2048
485b3b1203 Add comments explaining use of entity glow 2022-10-30 16:53:45 +01:00
x2048
bf1cc1bb84 Apply entity glow before translating to color space 2022-10-30 16:53:45 +01:00
x2048
3e7ee499d6 Always add increment when getting node interior light 2022-10-30 16:53:45 +01:00
x2048
a075d83752 Use the same light level for non-solid draw types as for solid 2022-10-30 16:53:45 +01:00
Lars Müller
077627181e
Allow rotating entity selectionboxes (#12379) 2022-10-30 16:53:14 +01:00
lhofhansl
b829231992
Fix incorrect culling introduced by ##12710 (#12887) 2022-10-28 09:52:54 -07:00
lhofhansl
9aaed75eea
Safety check the map's blocksize (#12895) 2022-10-27 19:31:42 -07:00
x2048
88820cd31c
Shadow list improvements (#12898) 
* Remove redundant checks when attaching SM texture to entities.
  Some of the checks were broken, leading to crashes when shadow intensity is set to 0
* Avoid memory leak in shadow casters list when wield mesh changes item stacks
 2022-10-26 22:26:09 +02:00
Jean-Patrick Guerrero
16266397ed
GUIInventoryList: Keep item size while moving (#12896) 2022-10-24 13:58:56 +02:00
Jude Melton-Houghton
e86d23daed
Check sizeof(int) and sizeof(size_t) 2022-10-23 21:59:12 +02:00
Riceball LEE
8bdedd2bcf
guiChatConsole: fix the unicode characters crowded together on prompt (#12867) 
Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>
 2022-10-21 17:12:07 +02:00
DS
7153cb8a0b
Fix formspec focus (#12795) 2022-10-21 17:11:41 +02:00
Jude Melton-Houghton
dafdb3edb4
Check for falling float nodes in liquid transform (#12862) 2022-10-18 18:03:05 -04:00
Jude Melton-Houghton
b38ffdec27
Implement vector and node conversion in Lua (#12609) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-10-18 18:01:44 -04:00
sfan5
87051fca26
Take geographic distance into account for server list ordering (#12790) 2022-10-17 07:56:28 -04:00
SmallJoker
5d8a4917c5
LocalPlayer: Fix sneaking on nodes with large collisionboxes (#12626) 2022-10-17 07:56:04 -04:00
sfan5
25c5400250 Exclude MSVC from new Lua sanity check 2022-10-15 12:02:02 +02:00
sfan5
f680d10259 Other minor CMake improvements 2022-10-13 23:02:11 +02:00
sfan5
e8ee4cb40d Defer searching for libintl to CMake 
resolves #12800
 2022-10-13 23:02:11 +02:00
sfan5
af38bae57f Get rid of LuaJIT linking workarounds 
...and replace them with a cautionary warning message if someone uses an old version.
The detection is kind of a hack but no choice as upstream is not interested in version numbering.
 2022-10-13 23:02:11 +02:00
sfan5
558cbd89fb Add extra check in case someone tries to unbundle Lua 2022-10-13 23:02:11 +02:00
Jude Melton-Houghton
cb725a4555 Speed up find_nodes_in_area (#12845) 2022-10-13 09:35:19 -04:00
fluxionary
6b6f886bcd
object ids are u16, not s16 (#12848) 2022-10-13 08:46:48 -04:00
Jude Melton-Houghton
f7ae70c3d9 Use enum to define custom registry indices 2022-10-13 08:46:16 -04:00
Jude Melton-Houghton
f073e37d2f Test on-lighting node param1 in lighting test 2022-10-13 08:46:16 -04:00
Jude Melton-Houghton
b3503e7853 Embed data directly in mapblocks 2022-10-09 13:43:48 -04:00
Jude Melton-Houghton
8f996e4a7c Remove unused MapBlock functionality 2022-10-09 13:43:48 -04:00
Jude Melton-Houghton
9676364c1f
Optimize lighting calculation (#12797) 2022-10-09 10:50:26 -04:00
fluxionary
440d966b93
add an 'equals' method to ItemStack and compatibility w/ lua '==' (#12771) 
Co-authored-by: rubenwardy <rw@rubenwardy.com>
Co-authored-by: sfan5 <sfan5@live.de>
 2022-10-09 08:06:09 -04:00
ROllerozxa
be5c675263
Only set quicktune keybinds in debug builds (#12779) 2022-10-06 17:07:57 +01:00
x2048
1e96403954 Use legacy call when rendering to a single texture 
Fixes depth buffer in when undersampling > 1
 2022-10-04 21:02:42 +02:00
Jude Melton-Houghton
7632af3c73
Consolidate API object code (#12728) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-10-04 08:31:36 -04:00
Jude Melton-Houghton
b21fb18379
Disable -ffinite-math-only (#12832) 2022-10-03 12:13:35 -04:00
sfan5
525fc3833c Implement tool use sounds 2022-09-30 14:02:14 +02:00
sfan5
bbdb1929c6 Clean up Game::handleDigging() and some related parts 2022-09-30 14:02:14 +02:00
Muhammad Rifqi Priyo Susanto
13a8948edd
Improve double tap for jump detection (#12793) 2022-09-30 14:02:06 +02:00
Jude Melton-Houghton
e832cee1e6
Avert collision static detection rounding error (#12822) 2022-09-30 06:31:24 -04:00
Wuzzy
6eb7d57ed3
Fix inconsistent craft replacements (#9250) (#12819) 2022-09-30 06:30:39 -04:00
Wuzzy
5e7ea0664a
Fix error msg if craft replacement w/ full inv (#12820) 2022-09-29 20:34:51 +02:00
x2048
9df79a4b2d
Bloom (#12791) 
Adds configurable light exposure control and bloom effect (light bleeding) with client-side settings.
 2022-09-29 20:34:05 +02:00
Muhammad Rifqi Priyo Susanto
3978b9b8ed
Add crosshair support for Android (#7865) 
If enabled, a crosshair will be shown to select object.
This will give Android players a way to play like they play on desktop.
On third-person back camera mode, player is forced to use crosshair.
On third-person front camera mode, player is unable to select anything.

Co-authored-by: ROllerozxa <temporaryemail4meh+github@gmail.com>
Co-authored-by: rubenwardy <rw@rubenwardy.com>
 2022-09-29 20:30:33 +02:00
20kdc
b1233056b7
Add zstd compression support (#12515) 2022-09-28 09:06:14 -04:00
DS
0251b01da6
Pause shader animation timer in singleplayer pause menu (#12766) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-09-27 16:23:07 -04:00
pecksin
6ac38aa2c8
Restore and enhance bouncy behavior (#11939) 2022-09-27 16:22:36 -04:00
savilli
907dcdcf7b
Add unittests for item movement code (#11885) 2022-09-27 16:22:11 -04:00
Wuzzy
3f801bc096
Fix liquid drawtype faces sometimes not rendering (#12807) 
Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>
 2022-09-26 19:27:47 -04:00
Jude Melton-Houghton
f4a01f3a5d
Avoid duplication of mod metadata in memory (#12562) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-09-26 17:03:43 -04:00
Jude Melton-Houghton
03428d9825
Modify PUC Lua to wrap C++ exceptions (#12445) 2022-09-26 07:23:48 -04:00
Jude Melton-Houghton
f916398a54
Add lighting test and benchmark (#12802) 2022-09-26 06:49:08 -04:00
Tobias Frost
7069d99aa6
Fix two spelling mistakes 
Co-authored-by: Tobias Frost <tobi@debian.org>
 2022-09-25 13:45:27 +02:00
Lars Müller
1317cd12d7
Fix formula used for acceleration (#12353) 2022-09-20 10:55:51 +02:00
DS
11905a6db6
Rename a variable in localplayer.h, resolves a TODO 2022-09-20 10:55:11 +02:00
ndren
2c3f641e0b
Simplify bit flip in sha1.cpp 2022-09-20 10:54:35 +02:00
Jude Melton-Houghton
006d974c58 Catch exceptions in SQLite3 callback 2022-09-18 17:39:09 +02:00
Jude Melton-Houghton
6f5a68b7f7
Allow getmetatable in CSM (#12776) 2022-09-18 17:32:18 +02:00
DS
c9ed059d91
Client map: do frustum culling via planes (#12710) 2022-09-18 15:28:53 +02:00
savilli
9428917870
Fix UAF in craft recipes (#12763) 
If you call minetest.clear_craft after minetest.register_alias_force, the craft definition reference may not be removed from m_output_craft_definitions leading to UAF.
 2022-09-16 13:20:14 +02:00
William Breathitt Gray
19e936362a
Add support for MINETEST_USERDATA environment variable (#12639) 
The MINETEST_USER_PATH environment variable can be used to define a
custom path for Minetest user data. If MINETEST_USER_PATH is empty or
unset, the HOME (or APPDATA on Windows) environment variable is used as
the default user data path; this ensures backwards compatibility with
existing user setups.
 2022-09-16 13:19:44 +02:00
Wuzzy
1d04903c19
Add paramtype2s for 4 horizontal rotations and 64 colors (#11431) 
4dir is like facedir, but only for 4 horizontal directions: NESW. It is identical in behavior to facedir otherwise. The reason why game makers would want to use this over facedir is 1) simplicity and 2) you get 6 free bits.
It can be used for things like chests and furnaces and you don't need or want them to "flip them on the side" (like you could with facedir).

color4dir is like colorfacedir, but you get 64 colors instead of only 8.
 2022-09-16 13:18:55 +02:00
DS
f3f3b752f2
Fix tooltips for dropdown, scrollbar and more (#12747) 2022-09-13 12:48:28 +01:00
SmallJoker
bc3dccca5c
Mainmenu: Properly sort mods and games (#12758) 
This also removes trivial and unused pkgmgr functions
Fixes a bug caused by sorting in 2133fc8
 2022-09-12 19:24:54 +02:00
Jude Melton-Houghton
fe13f9dfd1
Fix potential use-after-free with item metadata (#12729) 
This fixes a use-after-free bug in the case where itemstack metadata is accessed after the itemstack has been garbage-collected.
 2022-09-11 19:28:37 +02:00
sfan5
c607bee19e Allow looped animation to be used safely with old clients 
fixes #12657
 2022-09-10 12:21:29 +02:00
pecksin
adb03ccc6d
Chat weblink: remove comma as delimiter (#12730) 2022-09-10 12:21:15 +02:00
DS
643971c948
Add documentation of sun/moon orientation/scale differences (#12145) 2022-09-06 11:21:55 +01:00
Herman Semenov
038da00e79
Code optimizations / refactor (#12704) 
Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>
Co-authored-by: sfan5 <sfan5@live.de>
 2022-09-06 11:21:09 +01:00
x2048
ff6dcfea82
Implement rendering pipeline and post-processing (#12465) 
Co-authored-by: Lars Mueller <appgurulars@gmx.de>
Co-authored-by: sfan5 <sfan5@live.de>
Co-authored-by: lhofhansl <lhofhansl@yahoo.com>
 2022-09-06 08:25:18 +02:00
x2048
464043b8ab Convert entity glow value to color space before adding to the light 2022-09-04 16:00:13 +02:00
fluxionary
0ab9bf926d
Fix texture_min_size 2022-08-24 22:38:14 +02:00
rubenwardy
2d10fa7867
Prevent loading a world with unresolved dependencies (#12542) 2022-08-19 12:31:36 +01:00
x2048
8c29c4f620
Use Sky class to obtain directional light source position for shadows (#12662) 
* Also remove unused Sky::getSkyBodyOrbitTilt method

Fixes misalignment of sun position and shadow direction at high tilt values.
 2022-08-17 16:30:05 +02:00
celeron55
3f67215df9
Log sockets into tracestream instead of dstream (#12701) 2022-08-16 15:18:11 +01:00
Elliott Lester
7c5e3cac6a
Apply DPI Scaling to GUIModalMenu (#12693) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-08-15 21:19:47 +01:00
x2048
aa2fdc6ef6
Limit force shadow update to urgent blocks (#12692) 2022-08-14 20:29:20 +02:00
Lion
2690585e99
Add handling of environment variables to control terminal/logging colors (#12641) 2022-08-14 20:27:28 +02:00
x2048
d1cbb4bd8a
Reduce the use of porting::getTimeMs() when rendering frames (#12679) 
* Avoid calling TimeTaker too frequently in renderMapXXX
* Calculate animation timer once per frame
* Remove code that breaks rendering frame at 2000ms

Co-authored-by: sfan5 <sfan5@live.de>

Co-authored-by: sfan5 <sfan5@live.de>
 2022-08-13 22:33:26 +02:00
Lars Müller
0e439b2fa3
Check hp_max > 0 for entities (#12667) 2022-08-13 15:35:41 +01:00
Jude Melton-Houghton
ab8dfb45b4
Allow buffer argument to VoxelManip:get_light_data (#12682) 2022-08-13 08:53:47 +02:00
fluxionary
59601eb922
Remove default keybind for range select (#12632) 
Reason: accidental key presses, few use-cases.
 2022-08-13 08:53:30 +02:00
SmallJoker
023a1c2427
Textures: introduce world-align overrides (#12540) 
Many games do not care about world align textures, however texture packs should have the capabilities to change that if they have suitable textures. This commmit now introduces a node property override for world-align in particular to force a certain scale on the selected override tiles.
 2022-08-13 08:52:16 +02:00
SmallJoker
c8ee755c05
Physics overrides: Move values to a common struct (#12591) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-08-12 10:17:02 +01:00
Zughy
bcc56803d7
Fix crash when stars are reset 2022-08-10 18:03:57 +02:00
sfan5
4fbcc33ee0 Enable C++ stdlib assertions in debug flags 2022-08-05 13:04:01 +02:00
sfan5
c4277877b6 Bump protocol version 
Better late than never.
 2022-08-04 22:45:52 +02:00
ROllerozxa
eb49b6d85c
Disable dynamic shadow dropdown on OGLES2 (#12637) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-08-04 20:42:43 +02:00
x2048
644f145ff2 Explicitly initialize value of particle parameter. Fixes #12621. 2022-08-02 23:51:50 +02:00
SmallJoker
a81259d19a
Run Minetest update checker on startup (#7629) 
This feature is enabled by default for non-Android release builds. Package
maintainers may use -DENABLE_UPDATE_CHECKER=0 to disable it.

Co-authored-by: rubenwardy <rw@rubenwardy.com>
Co-authored-by: sfan5 <sfan5@live.de>
 2022-08-02 21:34:17 +02:00
sfan5
f22d40975e Switch MeshUpdateQueue to better data structure 2022-08-02 11:58:26 +02:00
sfan5
4c1ef1b72b Ratelimit MeshUpdateQueue::cleanupCache() runs 2022-08-02 11:58:26 +02:00
AFCMS
6ec6acc539
Add minetest.settings to CSM API and allow CSMs to provide settingtypes.txt (#12131) 
Co-authored-by: sfan5 <sfan5@live.de>
Co-authored-by: SmallJoker <SmallJoker@users.noreply.github.com>
 2022-08-02 11:58:08 +02:00
x2048
839600ed70
Use legacy image implementation (no NNAA filter) when not using 9-slice image (#12608) 2022-07-31 21:57:13 +02:00
Mantar
95d7fcb949
Apply NetBSD string conversion workaround to OpenBSD as well (#12618) 2022-07-31 15:18:19 +02:00
ROllerozxa
de509d05e6
Fix Android blank screen (#12604) 
Hardcode the variables to 0 on Android
 2022-07-31 15:18:04 +02:00
SmallJoker
c14b7536a4 HUD: Fix wrong minimum scale since 051181f 
Caused by wrong interpretation of the settingtypes.txt format
 2022-07-31 14:57:19 +02:00
rubenwardy
a871115889
Fix some warnings (#12615) 2022-07-30 12:51:23 +01:00
Lars Müller
99c8295e71
Fix media overriding regression (#12602) 2022-07-29 10:19:36 +02:00
sfan5
6611d7e1ee Allow direction keys with autoforward again 
This was unintentionally removed in commit 1d69a23.
fixes #12048
 2022-07-29 10:19:23 +02:00
Jude Melton-Houghton
d631f21024
Let core.get_mod_storage be called multiple times (#12572) 2022-07-23 22:27:07 +02:00
updatepo.sh
eea2a97475 Update minetest.conf.example 2022-07-20 21:36:03 +02:00
x2048
70c54abc2a
Restore flags texture to fix interlaced stereo mode (#12560) 2022-07-19 20:26:57 +02:00
x2048
b270a46e53
Offset cuboid origin after scaling the cuboid. (#12558) 
This avoids the problem of offset nodes with visual_scale > 1.
 2022-07-19 10:48:00 +02:00
Lars Müller
d400a98ef0
Fix automatic rotate for attached entities (#12392) 2022-07-17 14:45:57 +01:00
x2048
7b6c4bf2e0
Remove workaround for normals not matching winding order (#12460) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-07-17 14:45:42 +01:00
rubenwardy
4648d8f499
Deprecate loading a world with unresolved dependencies (#12541) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-07-17 14:45:20 +01:00
rubenwardy
9f41b4f72d Add check_mod_configuration to main menu 2022-07-14 22:12:54 +01:00
rubenwardy
06de82fd86 Refactor ModConfiguration 2022-07-14 22:12:54 +01:00
sfan5
1d512ef7f4 Reduce code duplication between c_converter.cpp and helper.cpp 2022-07-14 20:55:45 +02:00
sfan5
8ff3fadba0 Remove unnecessary float limits from script API 
Leaves a check for NaN and inf.
 2022-07-14 20:55:45 +02:00
sfan5
137eef6590 Move f1000 sanitizing to the places that still use this type 2022-07-14 20:55:45 +02:00
SmallJoker
f4c6ed863d
GUIFormSpecMenu: Fix label multiline translation (#12527) 2022-07-14 20:51:01 +02:00
Dmitry Kostenko
6df69f9b5b Make BlendMode::alpha the fallback for unknown future blend modes 2022-07-13 22:45:05 +02:00
Lexi Hale
20bd6bdb68
Animated particlespawners and more (#11545) 
Co-authored-by: Lars Mueller <appgurulars@gmx.de>
Co-authored-by: sfan5 <sfan5@live.de>
Co-authored-by: Dmitry Kostenko <codeforsmile@gmail.com>
 2022-07-13 11:57:12 +02:00
SmallJoker
8724fe6e3f GUIFormSpecMenu: Fix parameter order 
Fixes a regression caused by e51f47461 because C++ implicitly converts boolean to float. no matter what.
 2022-07-10 15:34:53 +02:00
SmallJoker
e51f474613
Sounds: Various little improvements (#12486) 
Use SimpleSoundSpec where reasonable (OpenAL)
Ensure the sound IDs do not underflow or get overwritten -> loop in u16
Proper use of an enum.
 2022-07-09 22:32:24 +02:00
SmallJoker
051181fa6e
Enforce limits of settings that could cause buggy behaviour (#12450) 
Enforces the setting value bounds that are currently only limited by the GUI (settingtypes.txt).
 2022-07-09 22:32:08 +02:00
x2048
7c261118e0
Release shadow mapping resources when not needed (#12497) 2022-07-09 22:26:39 +02:00
Vincent Robinson
f7bcf7fa46
FormSpec: 9-slice images, animated_images, and fgimg_middle (#12453) 
* FormSpec: 9-slice images and animated_images

* Add fgimg_middle; clean up code

* Address issues, add tests

* Fix stupid error; bump formspec version

* Re-add image[] elements without a size
 2022-07-03 08:52:26 -04:00
Wuzzy
142928e944
Allow to set maximum star opacity at daytime (#11663) 2022-07-02 19:57:48 +01:00
sfan5
a5f385917d Remove an unused method and header includes 2022-06-28 12:21:12 +02:00
Zughy
18fbc0394b
Remove tile_images and special_materials obsolete code (#12455) 
Co-authored-by: Zughy <4279489-marco_a@users.noreply.gitlab.com>
 2022-06-28 00:55:01 +01:00
ROllerozxa
35ad006234
Increase max FPS on Android to 60 (#12373) 2022-06-26 14:38:11 +01:00
JosiahWI
4163c872af
Fix two memleak reports from Coverity (#12466) 2022-06-26 14:37:50 +01:00
SmallJoker
a463620edb
Re-order sound-related code (#12382) 
Dropped ServerSoundParams -> moved to ServerPlayingSound. This gets rid of the duplicated
'fade' and 'pitch' values on server-side where only one was used anyway.
SimpleSoundSpec is the basic sound without positional information, hence 'loop' is included.

Recursively added PROTOCOL_VERSION to most functions to reduce the versioning mess in the
future. Per-type version numbers are kept for now as a safety rope in a special case.
 2022-06-20 21:56:12 +02:00
sfan5
0b41533763
Annotate light spread functions with comments 2022-06-20 21:24:28 +02:00
sfan5
e92a217bd1 Fix CAO light calculation issue 2022-06-19 13:30:11 +02:00
sfan5
a83d81ff45 Fix updating glow on entities 
was broken in #10021 more than 2 years ago(!)
 2022-06-17 20:50:24 +02:00
savilli
ae555465ba
Fix zlib (de)compressor memory leaks 2022-06-16 23:53:23 +02:00
Nathanaël Courant
622d857bed Update my name 2022-06-16 21:38:32 +02:00
sfan5
e9e721b937 Fix entity related bugs 
* Make minetest.add_entity() binary-safe
* Fix on_death pushing dummy ObjectRef instead of nil
 2022-06-15 17:20:07 +02:00
ROllerozxa
992f501159 Fix Android input box crash 2022-06-14 19:22:22 +02:00
paradust7
7ffc0268df
Inline triLinearInterpolationNoEase and triLinearInterpolation (#12421) 
Performance profiling on Linux AMD64 showed this to be a significant bottleneck. The non-inlined functions are expensive due to XMM registers spilling onto the stack.
 2022-06-11 20:01:30 +02:00
Lars Müller
e7d4ec6834
on_deactivate: distinguish removal and unloading (#11931) 
Sometimes you need to be able to do removal-related cleanup, such as removing files from disk, or entries from a database. staticdata obviously isn't suitable for large data. The data shouldn't be removed if the entity is unloaded, only if it is removed.
 2022-06-11 20:01:14 +02:00
Lars Müller
f4a53f7ee6
No damage effects on hp_max change (#11846) 2022-06-11 20:00:40 +02:00
sfan5
3ac5a24b12
Sanitize player position and speed server-side (#12396) 2022-06-07 21:27:05 +02:00
x2048
3107c98591
Mapblock Mesh BspTree: Increase the depth of block-level splits 
... before going node-level triangle search.
Fixes transparent grass on transparent land
 2022-06-07 21:26:31 +02:00
paradust7
951604e29f Remove invalid fps_max on Mac 2022-06-06 12:03:28 +02:00
sfan5
14c283a623 Fix crash in commit a69b7abe00 2022-06-05 19:00:14 +02:00
rubenwardy
4baf56520d
Android: Add support for sharing debug.txt (#12370) 2022-06-05 17:42:09 +01:00
sfan5
a69b7abe00 Improve LBMManager::applyLBMs() code 
Fixes a possible bug for lbms on content ID zero and removes unsafe casts.
 2022-06-05 17:48:51 +02:00
rubenwardy
03d86ea0b4
Add register dialog to separate login/register (#12185) 
New users find Minetest's account system confusing.
This change moves username/password to a new dialog,
with login and register buttons added to the Join Game tab.

The old registration confirmation dialog is removed in
favour of the new dialog.

Fixes #8138
 2022-06-05 17:47:38 +02:00
savilli
1f39948bc3
Fix BSD iconv declaration 2022-06-05 15:20:29 +02:00
JosiahWI
8e5bd82c4d
fix integer overflow in mapgen (#11641) 
* fix integer overflow in mapgen

Some calculations involving the magic seed had overflow because the result of an intermediate arithmetic step could not fit in an s32. By making the magic seed unsigned, the other operand in the equation will be cast to unsigned, and possibly other operands or intermediate operands. This will result in unexpected behavior if an operand is negative, which is technically possible, but logically should not happen.

* comment noise2d bitshift

While working through the code I was momentarily concerned that the right bitshift in noise2d could fill ones in some cases. It turns out that with signed integers, this is indeed true, but this one is shifting an unsigned integer, so the behavior is as expected. I put a comment here to clarify this, in case someone else wonders the same thing down the line.

* noise2d and noise3d unittests

I have added 3 tests each for noise2d and noise3d, testing all zero inputs, a very large seed (case which caused UB in the old implementation) and some fun primes I picked for no particular reason. This should be sufficient to demonstrate that the behavior of the new implementation has not changed. I used uniform initialization because it is a good feature of C++11. Please do not explode.

* uncomment the noise2d bitshift

This reverts commit 583b77ee9f. It's a
well-defined language semantic; it doesn't need to be commented.

* code cleanliness
 2022-06-03 20:51:58 -04:00
sfan5
575caa8015 Properly keep noclip state in Game and ClientMap 2022-06-03 21:48:52 +02:00
sfan5
5f3af7d18b Remove obsolete eye_height related workaround 
This was added a long time ago in 42bbd5c9ae
and meant to fix prevent the view becoming black when jumping into a
ceiling, this no longer happens today.
 2022-06-03 21:48:52 +02:00
Wuzzy
6a6b579c54
Add helper functions to make tool usable n times (#12047) 2022-06-03 21:47:04 +02:00
sfan5
9fc018ded1 Fix use-after-free in node meta cleanup 
bug introduced in 8908a91016
 2022-05-29 16:30:13 +02:00
sfan5
a9a207685a Reject registering node with empty name 
fixes #10769
 2022-05-29 14:00:19 +02:00
sfan5
c1d03695d4 Minor code improvements around active block keeping 2022-05-29 14:00:19 +02:00
sfan5
ea74680df4 Immediately activate blocks when a player joins 
issue: #10884
This makes it possible for objects to immediately be activated,
but doesn't guarantee it since blocks may still need be emerged.
 2022-05-29 14:00:19 +02:00
stefan
bb671c3089 Remove debug.get/setmetatable from security whitelist 
fixes #12216
 2022-05-29 14:00:19 +02:00
sfan5
303329f2d6 Handle lua entity HP changes correctly (like punches) 
fixes #11975
 2022-05-29 14:00:19 +02:00
sfan5
85c824ed13 Make sure real disconnect reason isn't overwritten 
bug introduced in 2f32044273
 2022-05-29 14:00:19 +02:00
sfan5
998e4820c9 Fix linking with Postgres libs on older cmake versions 
closes #12149
 2022-05-29 14:00:19 +02:00
sfan5
5cd7b0c6e4 Remove remains of video mode querying 2022-05-29 14:00:19 +02:00
sfan5
8908a91016 Get rid of node metadata when it becomes empty 
fixes #8943
 2022-05-29 14:00:19 +02:00
sfan5
261a8db9dd Optimize Server::sendMetadataChanged a bit 
The distance check also never worked as intended, now fixed.
 2022-05-29 14:00:19 +02:00
sfan5
f195db2d14 Add API function to invoke player respawn 
closes #12272
 2022-05-29 14:00:19 +02:00
sfan5
da71e86633 Protect a few more settings from being set from mods 
Of those settings main_menu_script has concrete security impact, the rest are added out of abundance of caution.
 2022-05-29 14:00:19 +02:00
sfan5
bccaf5fc2d Map opaque waving leaves to allfaces drawtype 
fixes #9842
 2022-05-29 14:00:19 +02:00
sfan5
0c6a029413 Improve a translation string 
fixes #11442
 2022-05-29 14:00:19 +02:00
x2048
ef22c0206f
Force-update shadows when the world is changed (#12364) 2022-05-26 22:28:34 +02:00
sfan5
8b74257bf3 Reduce size of ContentFeatures structure 
On my system this is a reduction from 4664 to 3704 bytes.
This is not for the sake of saving RAM but ensuring
commonly used structures fit into caches better.
 2022-05-26 15:49:12 +02:00
sfan5
9a01581cdd Get rid of global buffer that would ruin concurrent MapBlock serialization 2022-05-26 15:49:12 +02:00
sfan5
5d26ac0088 Improve code in mapblock_mesh.cpp a bit 2022-05-26 15:49:12 +02:00
x2048
ed26ed5a1f
Quantize light frustum calculations (#12357) 
* Quantize light frustum calculations

Reduces shadow flicker

* Fix function name to match conventions
 2022-05-23 23:45:18 +02:00
sfan5
5daafc9d33 Fix hash implementation for SerializedBlockCache 2022-05-23 22:50:58 +02:00
Richard Try
e16a470d59
Use unordered_map instead of map for MapSectors 2022-05-23 22:50:49 +02:00
paradust7
367a2d4b29
Add missing concurrency protection in logger (#12325) 2022-05-23 22:50:25 +02:00
Wuzzy
0f9c78c3eb
Fix no_texture.png for unknown nodes with ID < 125 (#12329) 2022-05-23 22:50:10 +02:00
paradust7
9f338f5a56
Replace all uses of core::list with std::list (#12313) 2022-05-22 00:11:59 +02:00
paradust7
2742fef458
Fixes needed to use irrArray backed by std::vector (#12263) 2022-05-22 00:11:49 +02:00
sfan5
2f32044273 Don't ignore server disconnects in client code 
If the server stops talking to us without saying bye we
should actually end the in-game session with an error message.
 2022-05-21 17:49:55 +02:00
sfan5
9ee3dc71f1 Optimize JSON string (de)serialization routines 
stringstreams were shown to be slow when reading/writing single characters
and there is lots of potential by having functions perform on existing
buffers whenever possible.
 2022-05-21 17:46:10 +02:00
sfan5
70dc23f996 Improve testSerializeJsonString unit tests 
this also removes the requirement that / is escaped, there is
no reason for doing so.
 2022-05-21 17:46:10 +02:00
rubenwardy
4e9e230e34
Deprecate game.conf name, use title instead (#12030) 2022-05-21 16:23:30 +01:00
x2048
dc45b85a54
Improve shadow filters (#12195) 
* Rewrite shadow filtering for the new distortion
* Calculate penumbra radius using a single sample
* Avoid peter-panning effect due to filtering of short shadows
* Add adaptive filter quality for soft shadows
* Avoid sharp shadows on surfaces without normals (e.g. plants)
* Increase default and maximum soft shadow radius
* Make line numbers in shader errors match the code
 2022-05-21 16:49:30 +02:00
x2048
a4ef62f5b2
Fix lighting of upright_sprite entities (#12336) 
Use MeshNode materials to set the light since ReadOnlyMaterials is now false
 2022-05-20 22:35:03 +02:00
x2048
604fb2b738
Fix lighting of the wield mesh (#12341) 
* Assign node light to player before final color blend.
  Fixes day/night lightbank ratio for wield meshes
* Update wield mesh light when changing mesh
 2022-05-20 22:33:52 +02:00
paradust7
273bfee9a1
Use std::map instead of core::map (#12301) 2022-05-18 12:31:49 +02:00
savilli
af37f9dc54
Remove confusing message in keybindings menu 2022-05-17 20:11:08 +02:00
Dmitry Kostenko
8756b7a735 Initialize wield mesh color when wield_image is set 
#12245
 2022-05-15 21:44:55 +02:00
sfan5
ec9f157512 Use native packer to transfer globals into async env(s) 2022-05-10 22:37:42 +02:00
Jude Melton-Houghton
7f58887ae3
Support packing arbitrary graphs (#12289) 2022-05-10 22:37:33 +02:00
Jude Melton-Houghton
d17d7eba14 Fix cooking and fuel crafts with aliases 2022-05-10 22:37:05 +02:00
Octavian
0f8c46771e Fix possible unreliable behavior due to uninitialized variables 2022-05-10 22:36:25 +02:00
sfan5
f5a8593b11
Add more Prometheus metrics (#12274) 2022-05-09 21:20:58 +02:00
Lars Müller
c2898f53bc
HUD: Update selection mesh every frame (#12270) 
Fixes outdated selection boxes after entity property changes.
 2022-05-09 20:43:47 +02:00
sfan5
a66e6d4dff Consolidate some data structures in MapBlockMesh 2022-05-08 19:12:10 +02:00
sfan5
1fa4f58080 Cache serialized mapblocks during sending 
This reduces the
(absolute) time spent in Server::SendBlocks() from 700ms to 300ms
(relative) share of MapBlock::serialize() from 80% to 60%
in a test setup with 10 players and many block changes
 2022-05-08 19:12:10 +02:00
ROllerozxa
f128f4cba1 Fix mapblock geometry optimisation not working 
Caused by the depth sorting PR marking not only transparent nodes to be ignored but also opaque ones with the TILE_MATERIAL_BASIC material type
 2022-05-08 19:11:44 +02:00
paradust7
87472150bc
Add benchmarks for json string serialize/deserialize (#12258) 
Co-authored-by: sfan5 <sfan5@live.de>
 2022-05-06 21:17:16 +01:00
Froggo
45d318a773
Enable chat clickable weblinks by default (#12115) 
Co-authored-by: rubenwardy <rw@rubenwardy.com>
 2022-05-06 21:15:16 +01:00
LoneWolfHT
47cf257c40
Fix Windows Visual Studio actions (#11176) 
Co-authored-by: rubenwardy <rw@rubenwardy.com>
 2022-05-04 22:55:02 +01:00
x2048
cc56ebd90d
Avoid rendering invisible faces of simple nodeboxes (#12262) 
* Skip rendering faces adjacent to opaque nodes
* Cancel out opposite faces of adjacent nodebox nodes of the same type

Fixes #6409
 2022-05-04 23:44:55 +02:00
Lars Müller
89c82035d8
hud_get: Return precision field for waypoints (#12215) 2022-05-04 20:55:20 +02:00
SmallJoker
3ce5a68cd1
guiScalingFilter: Fix most memory leaks (#12256) 
Calls to the cache function ended up creating a new texture regardless whether
the texture is already cached.
 2022-05-04 20:55:13 +02:00
paradust7
0704ca0550
Make logging cost free when there is no output target (#12247) 
The logging streams now do almost no work when there is no output target for them.

For example, if LL_VERBOSE has no output targets, then `verbosestream << x` will return a StreamProxy with a null target. Any further `<<` operations applied to it will do nothing.
 2022-05-04 20:55:01 +02:00
sfan5
71a56c3552 Fix broken FPS/dtime counters in debug info 
was broken by a89afe1229
 2022-05-03 20:17:43 +02:00
sfan5
e7659883cc Async environment for mods to do concurrent tasks (#11131) 2022-05-02 20:56:06 +02:00
sfan5
663c936428 Fix synchronization issue at thread start 
If a newly started thread immediately exits then m_running would
immediately be set to false again and the caller would be stuck
waiting for m_running to become true forever.
Since a mutex for synchronizing startup already exists we can
simply move the while loop into it.

see also: #5134 which introduced m_start_finished_mutex
 2022-05-02 20:54:55 +02:00
sfan5
56a558baf8 Refactor some Lua API functions in preparation for async env 2022-05-02 20:54:55 +02:00
sfan5
5362f472ff Remove some unused variable from Lua class wrappers 2022-05-02 20:54:55 +02:00
x2048
c7bcebb628
Initialize wield mesh colors when changing item. (#12254) 
Fixes #12245
 2022-05-01 17:21:00 +02:00
sfan5
a89afe1229 Deal with compiler warnings 2022-04-30 16:49:41 +02:00
sfan5
faecff570c Enable additional warning flags 
also make them work with the RelWithDebInfo build type
 2022-04-30 16:49:41 +02:00
sfan5
a65f6f07f3 Clean up some auth packet handling related code 2022-04-28 20:05:26 +02:00
sfan5
00f71c3b9d Fix password changing getting stuck if wrong password is entered once 2022-04-28 19:55:36 +02:00
sfan5
3d2bf8fb02 Apply disallow_empty_password to password changes too 2022-04-28 19:55:36 +02:00
sfan5
391eec9ee7 Fix race condition in registration leading to duplicate create_auth calls 2022-04-28 19:55:36 +02:00